Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the recent discussions, it sounds like everyone supports the idea of publishing releases.
So, now that #2917 is merged, this PR adds a button to the GitHub UI, which a maintainer can click to publish a new version to npm:
There's no authentication tokens required, and this runs completely in the CI, maintainers don't need to run any commands locally.
Before this can be merged, there are a few extra steps that a maintainer needs to take (click to expand)
npm. Setup whatever restrictions you want, like only allowing deployments from thegh-pagesbranch.Once these two steps are done, publishing will work from the GitHub CI without needing to setup any other authentication or permissions. (thanks to the 'trusted publishing' feature)